This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
- From: Max Bowsher <maxb1 at ukf dot net>
- To: cygwin-apps at cygwin dot com
- Date: Thu, 09 Mar 2006 23:13:58 +0000
- Subject: Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
- Openpgp: id=C0F2C580
- References: <Pine.GSO.4.63.0601231209000.18707@access1.cims.nyu.edu> <Pine.GSO.4.63.0601310950260.2628@access1.cims.nyu.edu> <Pine.GSO.4.63.0603090938030.13150@access1.cims.nyu.edu>
- Reply-to: "capps >> cygwin-apps"@cygwin.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Igor Peshansky wrote:
>> 2006-01-23 Igor Peshansky <pechtcha@cs.nyu.edu>
>>
>> * script.cc (Script::run): Fix inverted test for abnormal exit.
>
> Ping (attached as "setup-script-exit-code-fix.patch-1").
Clearly correct, please commit.
>> 2006-01-31 Igor Peshansky <pechtcha@cs.nyu.edu>
>>
>> * script.cc (Script::run): Fix inverted test for abnormal exit.
>> Do not rename to ".done" unless completed successfully.
>
> And ping (attached as "setup-script-exit-code-fix.patch").
Do we necessarily want to try to re-run failed scripts the next time
setup installs some packages?
Perhaps renaming to ".failed" would be better that not renaming.
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
iD8DBQFEELa2fFNSmcDyxYARAtZgAKCMt94Mi7e30wXEBuVWFMiKPmn5IwCghUTV
zlM8FB3Pj9Ka7DMKsMG7F44=
=dpUu
-----END PGP SIGNATURE-----