cygport cygautoreconf failure with AC_CONFIG_MACRO_DIRS

[Brian Inglis]

On 2023-08-09 15:55, Jon Turney via Cygwin-apps wrote:
> On 08/08/2023 19:40, Brian Inglis via Cygwin-apps wrote:
>> On 2023-08-08 12:14, Jon Turney via Cygwin-apps wrote:
>>> On 03/08/2023 17:21, Brian Inglis via Cygwin-apps wrote:
>>>> Trying to build updated jq package, get cygautoreconf directory creation and 
>>>> existence bugs.
>>>> Cygport dies processing AC_CONFIG_SUBDIRS([modules/oniguruma]) under two 
>>>> levels of AS_IF (which handle existence of oniguruma library module or 
>>>> libonig-devel at default or custom locations with or without configure 
>>>> scripts in configure.ac) with:
>>>>
>>>> Could not find modules/oniguruma/configure.ac or modules/oniguruma/configure.in

>>> I'm not able to reproduce this problem.
>>>
>>> Can you provide the jq.cygport you are using.
>>>
>>> Also, can you be clear as to whether you have libonig-devel installed or not?

>> Attached jq.cygport.
>>
>> As the cygport debug prep make log shows, libonig-devel is in 
>> DEPEND/BUILD_REQUIRES and installed.
>>
>> Installed cygport is latest available 0.36.6-1.
>>
>> With the attached cygautoreconf patch applied, it builds.

> Thanks.
> 
> So, I think the ultimate cause of the error is that you changed the SRC_URI from 
> that for "a file uploaded for this release" (an archive presumably generated by 
> 'make dist' or equivalent) to "an archive automatic generated from git at the tag".
> 
> The later is (for obvious reasons) missing the files for git submodules, in this 
> case modules/oniguruma.
> 
> Your proposed fix is effectively making the existence of the directories named 
> in AC_CONFIG_SUBDIRS optional.  I'm not sure that's correct or warranted.

Hi Jon,

The previous maintainers have been inactive for 5 years, so they have started a 
new org, working on a new release, and announced rc1, so I am working with them 
to resolve a test failure, prior to posting a Cygwin ITA.

	https://github.com/jqlang/jq/releases

I just noticed that they have now posted a newer prerelease "rc1"!

I can look at those contents later to see if they include the module, and that 
issue is resolved.

> That leaves the second part of your patch.  I'm not sure if you're claiming this 
> is the same problem, a similar problem, or a different problem.

That adds cygport cygautoreconf support for a newer AC_CONFIG_MACRO_DIRS macro 
to existing support for the older AC_CONFIG_MACRO_DIR macro.

> Anyhow, out of time for staring at the wall of words for today, I'll have to 
> look at that again later...

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry