[newlib-cygwin] Cygwin: AF_INET and AF_LOCAL: recv_internal: fix MSG_WAITALL support
Ken Brown
kbrown@sourceware.org
Fri Oct 23 12:23:57 GMT 2020
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3752ab804bda1cbb38b5da91db8cf14f8bdefa2f
commit 3752ab804bda1cbb38b5da91db8cf14f8bdefa2f
Author: Ken Brown via Cygwin-patches <cygwin-patches@cygwin.com>
Date: Mon Oct 12 14:02:13 2020 -0400
Cygwin: AF_INET and AF_LOCAL: recv_internal: fix MSG_WAITALL support
If MSG_WAITALL is set, recv_internal calls WSARecv or WSARecvFrom in a
loop, in an effort to fill all the scatter-gather buffers. The test
for whether all the buffers are full was previously incorrect.
Diff:
---
winsup/cygwin/fhandler_socket_inet.cc | 2 +-
winsup/cygwin/fhandler_socket_local.cc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_socket_inet.cc b/winsup/cygwin/fhandler_socket_inet.cc
index 71e92e341..bc08d3cf1 100644
--- a/winsup/cygwin/fhandler_socket_inet.cc
+++ b/winsup/cygwin/fhandler_socket_inet.cc
@@ -1208,7 +1208,7 @@ fhandler_socket_inet::recv_internal (LPWSAMSG wsamsg, bool use_recvmsg)
--wsacnt;
}
}
- if (!wret)
+ if (!wsacnt)
break;
}
else if (WSAGetLastError () != WSAEWOULDBLOCK)
diff --git a/winsup/cygwin/fhandler_socket_local.cc b/winsup/cygwin/fhandler_socket_local.cc
index 8bfba225a..c94bf828f 100644
--- a/winsup/cygwin/fhandler_socket_local.cc
+++ b/winsup/cygwin/fhandler_socket_local.cc
@@ -1212,7 +1212,7 @@ fhandler_socket_local::recv_internal (LPWSAMSG wsamsg, bool use_recvmsg)
--wsacnt;
}
}
- if (!wret)
+ if (!wsacnt)
break;
}
else if (WSAGetLastError () != WSAEWOULDBLOCK)
More information about the Cygwin-cvs
mailing list