This is the mail archive of the
cygwin-developers
mailing list for the Cygwin project.
Re: Performance optimization in av::fixup - use buffered IO, not mapped file
On Dec 12 13:03, Daniel Colascione wrote:
> On 12/12/2012 1:32 AM, Corinna Vinschen wrote:
> > On Dec 11 19:13, Daniel Colascione wrote:
> >> On 12/11/2012 5:06 PM, Daniel Colascione wrote:
> >>> On 12/10/2012 7:51 PM, Daniel Colascione wrote:
> >>>> The key to generating a binary that repros the problem is to unexec emacs, then
> >>>> try to repro with that generated binary, not a copy of it.
> >>>
> >>> The real explanation is a lot simpler: the binary is sparse. When you create a
> >>> file mapping object for a sparse file, Windows discards all cached pages for
> >>> that file. It makes sense that compilers (and Emacs unexec) would create sparse
> >>> files as they seek around inside their outputs.
> >>
> >> Anyway, the binary is sparse because our linker produces sparse files.
> >>
> >> Would the Cygwin developers accept this patch?
> >
> > It's ok with me to remove this code
>
> On second thought, this patch probably isn't the best idea. Windows might fix
> this behavior. Maybe it's better to add a per-OS-version flag.
>
> > , but there's a small problem. On
> > 2012-08-17, you wrote off-list, that you're going to send the signed
> > copyright assignment form. I never got the ok from my manager. Did you
> > miss to send the CA, or did my manager miss to inform me?
>
> I did send it. Can you check with management? If it never arrived, I can send
> another copy easily enough.
I'll check.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat